[pkg/ottl] added flag path #34736
Open
[pkg/ottl] added flag path #34736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niko-renko
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
|
|
bacherfl
reviewed
Aug 20, 2024
| @@ -127,6 +127,8 @@ func SpanPathGetSetter[K SpanContext](path ottl.Path[K]) (ottl.GetSetter[K], err | |||
| } | |||
| } | |||
| return accessStatus[K](), nil | |||
| case "flags": | |||
There was a problem hiding this comment.
as this is a new accessible property added to the span context, can you please also add an entry in the readme?
| @@ -585,3 +587,17 @@ func accessStatusMessage[K SpanContext]() ottl.StandardGetSetter[K] { | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| func accessFlags[K SpanContext]() ottl.StandardGetSetter[K] { | |||
There was a problem hiding this comment.
please also add a test case for accessing flags to the unit test of the SpanPathGetSetter
added 2 commits
August 20, 2024 10:20
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cannot access flags from span context. Making a statement that uses flags will fail.
Fixes the bug by adding the
flagspath.Link to tracking Issue:
Closes #34739
Testing:
None
Documentation:
N/A